New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(client): run functional tests in Data Proxy simulator #15010
Conversation
packages/client/src/__tests__/integration/happy/blog-env-postgresql/test.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/interactive-transactions/__snapshots__/tests.ts.snap
Outdated
Show resolved
Hide resolved
d8ee95b
to
11b2add
Compare
11b2add
to
6bd4d6f
Compare
Note:
Seems to be build artifacts and could be removed from git? But maybe it's only possible once it's moved in a separate package? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jolg42 they are build artifacts, yes. I left comments about them above. They will be removed once |
Good point about the publish pipeline. I didn't run it in the test pipeline on Buildkite intentionally and added Node.js 14 to the matrix on GitHub Actions instead to avoid running it twice (once with |
Discussed offline: |
This reverts commit bf6dc0b.
d64ca7e
to
3f47512
Compare
This reverts commit bfd9395 because it breaks TEST_SKIP_* logic.
It is now possible to use
pnpm test:functional --data-proxy
orpnpm test:functional --data-proxy --edge-client
to run the functional tests in Mini-Proxy — the local Data Proxy simulator specifically made for use in tests (internal: repo).It is similar to how, e.g., Cloudflare has Miniflare, but is an internal tool for now.
Although it doesn't share any code or architecture with the actual Data Proxy and is significantly simpler implementation of the Data Proxy API, the expectation is it should be a reasonable approximation for use in Prisma Client tests and allow us to have more confidence in the
DataProxyEngine
code and faster feedback loop. However, it is still essential to haveecosystem-tests
running with the real Data Proxy.Note:
bash
andopenssl
need to be installed and available inPATH
for this to work on Windows.Closes https://github.com/prisma/client-planning/issues/80
Use this to make some diffs in tests manageable to read: