Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): remove retries for all errors except network connection/socket errors #15684

Merged
merged 55 commits into from Nov 23, 2022
Merged

fix(client): remove retries for all errors except network connection/socket errors #15684

merged 55 commits into from Nov 23, 2022

Conversation

danstarns
Copy link
Contributor

@danstarns danstarns commented Oct 6, 2022 •
edited by aqrln

The binary engine had retry logic that was causing inconsistent behavior for users.

See https://prisma-company.slack.com/archives/CUXLS0Z6K/p1664962929905829

  • Removes retries for all write operations using the BinaryEngine.
  • Removes retires for all batch operations --if a child request contains a write--.

This PR closes #12862 and contains tests to assert that.

@danstarns danstarns requested review from a team and aqrln and removed request for a team October 6, 2022 08:48
@danstarns
Copy link
Contributor Author

Fixes: #15602

@garrensmith

This comment was marked as outdated.

Sign in to view
@danstarns danstarns changed the title refactor(client): remove retries refactor(client): remove retries for all errors except network connection/socket errors Oct 20, 2022
@danstarns danstarns changed the title refactor(client): remove retries for all errors except network connection/socket errors fix(client): remove retries for all errors except network connection/socket errors Oct 20, 2022
@aqrln aqrln merged commit e50510f into main Nov 23, 2022
@aqrln aqrln deleted the remove-retries branch November 23, 2022 22:00
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@danstarns @aqrln @jkomyno
fix(client): remove retries for all errors except network connection/…
63c30b8 
…socket errors (#15684)

Only retry network-related errors in BinaryEngine, and only if those didn't occur during a write operation.

Fixes: #12862
Co-authored-by: Alexey Orlenko <alex@aqrln.net>
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@danstarns @aqrln @jkomyno
fix(client): remove retries for all errors except network connection/…
a8c01da 
…socket errors (#15684)

Only retry network-related errors in BinaryEngine, and only if those didn't occur during a write operation.

Fixes: #12862
Co-authored-by: Alexey Orlenko <alex@aqrln.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

@SevInf SevInf Awaiting requested review from SevInf

@Jolg42 Jolg42 Awaiting requested review from Jolg42

@jkomyno jkomyno Awaiting requested review from jkomyno

@millsp millsp Awaiting requested review from millsp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Some errors are obfuscated by interactive transactions when using binary engine
5 participants
@danstarns @garrensmith @aqrln @millsp @janpio