fix(client): Serialize all Floats in exponential notation #15879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cmd-johnson
changed the title
It does not seem that it was indendened for snapshot serizier to apply to select.test.ts. Instead, we are fixing the failure by changing the number so it won't be replaced by serializer.
SevInf
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Hi @cmd-johnson!
Thank you for the great contribution, especially adding both unit & integration tests!
I've made a couple of changes to the PR:
- converted intergration test to a functional one. This a newer, more powerful test suite and we generally add new tests there and consider integration suite to be a legacy.
Once CI is green, I'll merge your contribution. Then, it will be released as a part of prisma 4.6.0.
|
Also fixes #15551 UPD: I went ahead and updated the PR message |
aqrln
approved these changes
Oct 19, 2022
Co-authored-by: Alexey Orlenko <alex@aqrln.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #12651, #13317 and #15551 by always serializing Float fields in GraphQL queries in exponential notation.
I added a unit test for the serialization and a integration test that verifies that large floats can now be inserted into the database and updated other tests that used floats to match the new serialization behavior.
In order to properly test this, I also had to change the regex used by the
jestSnapshotSerializerinnormalizeMigrateTimestamps, because it interfered with all long numbers in snapshots. E.g.-9.007199254740991e+15would get replaced with-9.202012310000001e+15, which made snapshots appear to test for a wrong value. I updated snapshots that had the same problem accordingly.Fixes #12651
Fixes #13317
Fixes #15551