test(generator-handler): Attempt to improve flaky test #15884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakiness `generatorHandler` waits for 200ms and if generator have not failed in this time considers it a success. This is results in quite flaky behaviour on CI. For now, attempting to overcome it by introducing the executable that fails faster. Ideally, the error handling logic of `generatorHandler` needs changing: it should explicictly confirm succesful startup.
SevInf
force-pushed
the
test/generator-handler-flake
branch
from
74bbbc2
to
381e2fb
Compare
SevInf
changed the title
|
Test in question was fixed in #15956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatorHandlerwaits for 200ms and if generator have not failed inthis time considers it a success. This is results in quite flaky
behaviour on CI. For now, attempting to overcome it by introducing the
executable that fails faster. Ideally, the error handling logic of
generatorHandlerneeds changing: it should explicictly confirmsuccesful startup.