Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update engines to 4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1 #15885

Merged

Conversation

prisma-bot
Copy link
Contributor

@prisma-bot prisma-bot commented Oct 19, 2022

Alberto's Description

This PR contains Rust engines updates for:

We unified the relationMode = "prisma" and relationMode = "foreignKeys" tests for the SetNull referential actions to let the CI pass and close #15683.

Original Bot Description

This automatic PR updates the engines to version 4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1. This will get automatically merged if all the tests pass.

Packages

Package NPM URL
@prisma/engines-version https://npmjs.com/package/@prisma/engines-version/v/4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1
@prisma/prisma-fmt-wasm https://npmjs.com/package/@prisma/prisma-fmt-wasm/v/4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1

Engines commit

prisma/prisma-engines@bc452eb701d4709e75729888e0ea0f53c19775d1

@prisma-bot prisma-bot requested a review from a team October 19, 2022 12:09
@prisma-bot prisma-bot requested review from aqrln and removed request for a team October 19, 2022 12:09
@jkomyno
Copy link
Contributor

jkomyno commented Oct 19, 2022

@Jolg42 I believe the failures seen here should answer this issue: #15683

@Jolg42 Jolg42 self-assigned this Oct 19, 2022
@Jolg42
Copy link
Member

Jolg42 commented Oct 19, 2022

I will look at this first thing tomorrow morning to unblock the pipeline.

It's weird that you could not reproduce the failure locally @jkomyno 🤔

@jkomyno
Copy link
Contributor

jkomyno commented Oct 19, 2022

Now the CI is green, @Jolg42 should be able to review and merge tomorrow morning

@mergery mergery bot merged commit ebee8a7 into main Oct 19, 2022
@mergery mergery bot deleted the deps/engines-4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1 branch October 19, 2022 20:44
@janpio
Copy link
Member

janpio commented Oct 19, 2022

As long as the tests pass and automerge label is present, Mergery will merge 🤷
We still need to make sure the changes in tests are valid, so please really double check @Jolg42 👍

Jolg42 added a commit that referenced this pull request Oct 20, 2022
Follows #15885

Since `NoAction` now behaves like `Restrict`, I could combine some tests

+ small typos fixes
@Jolg42
Copy link
Member

Jolg42 commented Oct 20, 2022

I created a follow up PR here #15901

jkomyno pushed a commit that referenced this pull request Oct 20, 2022
* test(relationMode): cleanup NoAction tests

Follows #15885

Since `NoAction` now behaves like `Restrict`, I could combine some tests

+ small typos fixes

* simplify errors for update/updateMany (same error)
@adamu
Copy link

adamu commented Oct 25, 2022

As long as the tests pass and automerge label is present, Mergery will merge 🤷

I am the Mergery author/maintainer. To be specific, Mergery merges when the merge button becomes green. You could add a branch protection rule to require a review, for example, which would prevent the merge button being green in this case.

@Jolg42
Copy link
Member

Jolg42 commented Oct 26, 2022

@adamu Thanks for the confirmation. It's also our understanding but it's easy to forget about removing the automerge label before doing an edit/push, and mergery is fast to merge 😄
I think one solution is to make some checks required, but it's not that easy because we might not need to require some checks for all PRs.

@janpio
Copy link
Member

janpio commented Nov 2, 2022

Thanks for the correct indeed. As @Jolg42 mentioned, our struggle here is that we just do not really need a review usually unless we manually modify the PR - and then we could also remove the automerge label but sometimes forget (before the tests make the merge button green).

Maybe there could be a way to automate the "if manually edited, additional check goes red until review is present" or " ... automerge is automatically removed" - but as this only goes "wrong" every few months I think we are good here. Unless someone feels motivated of course to play around with things 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants