New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update engines to 4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1 #15885
chore(deps): update engines to 4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1 #15885
Conversation
…8e0ea0f53c19775d1
I will look at this first thing tomorrow morning to unblock the pipeline. It's weird that you could not reproduce the failure locally @jkomyno 🤔 |
Now the CI is green, @Jolg42 should be able to review and merge tomorrow morning |
As long as the tests pass and |
Follows #15885 Since `NoAction` now behaves like `Restrict`, I could combine some tests + small typos fixes
I created a follow up PR here #15901 |
* test(relationMode): cleanup NoAction tests Follows #15885 Since `NoAction` now behaves like `Restrict`, I could combine some tests + small typos fixes * simplify errors for update/updateMany (same error)
I am the Mergery author/maintainer. To be specific, Mergery merges when the merge button becomes green. You could add a branch protection rule to require a review, for example, which would prevent the merge button being green in this case. |
@adamu Thanks for the confirmation. It's also our understanding but it's easy to forget about removing the |
Thanks for the correct indeed. As @Jolg42 mentioned, our struggle here is that we just do not really need a review usually unless we manually modify the PR - and then we could also remove the Maybe there could be a way to automate the "if manually edited, additional check goes red until review is present" or " ... |
Alberto's Description
This PR contains Rust engines updates for:
NoAction
should be alias ofRestrict
whenrelationMode = "prisma"
prisma-engines#3276We unified the
relationMode = "prisma"
andrelationMode = "foreignKeys"
tests for theSetNull
referential actions to let the CI pass and close #15683.Original Bot Description
This automatic PR updates the engines to version
4.6.0-4.bc452eb701d4709e75729888e0ea0f53c19775d1
. This will get automatically merged if all the tests pass.Packages
@prisma/engines-version
@prisma/prisma-fmt-wasm
Engines commit
prisma/prisma-engines@bc452eb701d4709e75729888e0ea0f53c19775d1