fix(client): middleware args consistency #15897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millsp
requested review from
a team and
danstarns
and removed request for
a team
millsp
changed the title
millsp
commented
Nov 8, 2022
danstarns
approved these changes
Nov 8, 2022
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Outdated
Show resolved
Hide resolved
danstarns
reviewed
Nov 8, 2022
packages/client/tests/functional/issues/15644-middleware-arg-types/tests.ts
Show resolved
Hide resolved
Co-authored-by: Daniel Starns <danielstarns@hotmail.com>
…middleware-arg-types
jkomyno
pushed a commit
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Daniel Starns <danielstarns@hotmail.com>
jkomyno
pushed a commit
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Daniel Starns <danielstarns@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15644
With this PR, we are fixing consistency issues in the shape of the arguments passed to middlewares.
To put it shortly, if you use an aggregate query like count, groupBy, or aggregate, the args you get in middleware are not exactly the ones you pass.
The reason for that is that we’ve added some “sugar” on top of the TS interfaces for aggregates to improve the DX, in turn it means we are transforming a nicer input into something that is understood by the Query Engine. That’s what ends up being passed to the middleware.
The solution is to pass the initial user input to the middlewares, not the one we have pre-transformed for the Query Engine (that should always be a hidden detail).