Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): wrong error for multiple queries in tx #15433 #15917

Closed
wants to merge 3 commits into from

Conversation

millsp
Copy link
Member

@millsp millsp commented Oct 20, 2022

No description provided.

@millsp millsp requested review from a team and aqrln and removed request for a team October 20, 2022 18:42
@millsp millsp marked this pull request as draft October 20, 2022 18:42

testMatrix.setupTestSuite(
(suiteConfig, suiteMeta) => {
test('example', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test('example', async () => {
test.failing('example', async () => {

@aqrln
Copy link
Member

aqrln commented Nov 25, 2022

Fixed by #16240, should we close this or should we merge the test?

@millsp
Copy link
Member Author

millsp commented Nov 25, 2022

I think we can close it :)

@millsp millsp closed this Nov 25, 2022
@aqrln aqrln deleted the correctness/15433-wrong-error-query-tx branch November 25, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants