Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client): Logging queries using binary engine with mongodb #15957

Merged
merged 22 commits into from
Nov 2, 2022
Merged

test(client): Logging queries using binary engine with mongodb #15957

merged 22 commits into from
Nov 2, 2022

Conversation

danstarns
Copy link
Contributor

@danstarns danstarns requested review from miguelff and a team October 24, 2022 11:10
@danstarns danstarns requested review from millsp and removed request for a team October 24, 2022 11:10
@danstarns danstarns added this to the 4.6.0 milestone Oct 24, 2022
Jolg42
Jolg42 requested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: use engines from main branch when merging

@miguelff
Copy link
Contributor

Hey @danstarns, I merged #15957. You can pull the latest changes to the engine and update your branch. Thank you!

@miguelff miguelff mentioned this pull request Oct 31, 2022
Closed
@danstarns danstarns requested review from Jolg42 and SevInf and removed request for jkomyno, millsp and Jolg42 October 31, 2022 23:24
@danstarns danstarns merged commit 228e9fa into main Nov 2, 2022
@danstarns danstarns deleted the test/logging-binary-mongodb branch November 2, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@Jolg42 Jolg42 Jolg42 approved these changes

@miguelff miguelff Awaiting requested review from miguelff

@SevInf SevInf Awaiting requested review from SevInf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danstarns @miguelff @janpio @SevInf @Jolg42