Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update engines to 4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5 #16160

Merged

Conversation

prisma-bot
Copy link
Contributor

This automatic PR updates the engines to version 4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5. This will get automatically merged if all the tests pass.

Packages

Package NPM URL
@prisma/engines-version https://npmjs.com/package/@prisma/engines-version/v/4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5
@prisma/prisma-fmt-wasm https://npmjs.com/package/@prisma/prisma-fmt-wasm/v/4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5

Engines commit

prisma/prisma-engines@24b1bccc0fd2e73994d1ad76742680dab5037ee5

@prisma-bot prisma-bot requested a review from a team November 7, 2022 08:29
@prisma-bot prisma-bot requested review from danstarns and removed request for a team November 7, 2022 08:29
@Jolg42 Jolg42 removed the automerge label Nov 7, 2022
@Jolg42
Copy link
Member

Jolg42 commented Nov 7, 2022

Related #16162 but won't be merged today.
We need to update the snapshots to unblock the engines.

@miguelff
Copy link
Contributor

miguelff commented Nov 7, 2022

On it! Thanks @Jolg42 !

miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. 

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. 

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
@Jolg42 Jolg42 merged commit d17e458 into main Nov 7, 2022
@Jolg42 Jolg42 deleted the deps/engines-4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5 branch November 7, 2022 10:55
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
Jolg42 pushed a commit that referenced this pull request Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160.

In particular, I found that:
1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set
1.  When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated.

This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.

[skip ci]
@janpio janpio added this to the 4.6.0 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants