-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update engines to 4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5 #16160
Merged
Jolg42
merged 2 commits into
main
from
deps/engines-4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5
Nov 7, 2022
Merged
chore(deps): update engines to 4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5 #16160
Jolg42
merged 2 commits into
main
from
deps/engines-4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related #16162 but won't be merged today. |
On it! Thanks @Jolg42 ! |
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
Jolg42
deleted the
deps/engines-4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5
branch
November 7, 2022 10:55
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
miguelff
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix.
Jolg42
pushed a commit
that referenced
this pull request
Nov 7, 2022
I faced a bit of friction in understanding how to update a snapshot in the scope of #16160. In particular, I found that: 1. `pnpm run test` from the root required `BUILDKITE_BRANCH` env var to be set 1. When running ` pnpm run test getDmmf -- -u` to update getDmmf snapshots, tests ran against the new snapshot but the snapshot was not updated. This patch clarifies a bit the docs accordingly, although the first issue (required env var) is not addressed, as I think that would require a different code fix. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatic PR updates the engines to version
4.6.0-51.24b1bccc0fd2e73994d1ad76742680dab5037ee5
. This will get automatically merged if all the tests pass.Packages
@prisma/engines-version
@prisma/prisma-fmt-wasm
Engines commit
prisma/prisma-engines@24b1bccc0fd2e73994d1ad76742680dab5037ee5