fix(qe): Ensure middleware for FindXOrThrow captures exceptions #16433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelff
requested review from
a team and
millsp
and removed request for
a team
aqrln
approved these changes
Nov 24, 2022
miguelff
force-pushed
the
fix/error-logging-middleware
branch
from
b60006f
to
2072444
Compare
miguelff
force-pushed
the
fix/error-logging-middleware
branch
from
2072444
to
ebf3da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16354 (more precisely, it tests that the problem was fixed in #16162)
To be shipped after #16287. Once #16287 is merged, this has to be rebased again main, and the base branch changed.