fix(client): Force result extensions to log correct properties
#16542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevInf
requested review from
a team and
aqrln
and removed request for
a team
SevInf
force-pushed
the
log-proxy
branch
2 times, most recently
from
9334ae6
to
b048a7c
Compare
SevInf
force-pushed
the
log-proxy
branch
2 times, most recently
from
fd863da
to
9b7c830
Compare
millsp
approved these changes
Nov 30, 2022
Node.js `util.inspect` and console functions deliberately avoid triggering any of the proxy traps. If result extensions are used, that forces us to show completely incorrect result - it will show the target which would not match what user is actually getting there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js
util.inspectand console functions deliberately avoidtriggering any of the proxy traps. If result extensions are used, that
forces us to show completely incorrect result - it will show the target
which would not match what user is actually getting there.
Fix #16554