Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update engines to 4.8.0-6.b5a1e814c11f68346141127705831bc69857f0f7 #16597

Merged

Conversation

prisma-bot
Copy link
Contributor

The base branch for this PR is: main
This automatic PR updates the engines to version 4.8.0-6.b5a1e814c11f68346141127705831bc69857f0f7.
This will get automatically merged if all the tests pass.
:warning! If this PR needs to be updated, first remove the automerge label before pushing to avoid automerge to merge without waiting for tests.

Packages

Package NPM URL
@prisma/engines-version https://npmjs.com/package/@prisma/engines-version/v/4.8.0-6.b5a1e814c11f68346141127705831bc69857f0f7
@prisma/prisma-fmt-wasm https://npmjs.com/package/@prisma/prisma-fmt-wasm/v/4.8.0-6.b5a1e814c11f68346141127705831bc69857f0f7

Engines commit

prisma/prisma-engines@b5a1e814c11f68346141127705831bc69857f0f7

@prisma-bot prisma-bot requested a review from a team December 2, 2022 13:41
@prisma-bot prisma-bot requested review from aqrln and removed request for a team December 2, 2022 13:41
@Jolg42
Copy link
Member

Jolg42 commented Dec 2, 2022

Note failures actually showed up first in #16596
from prisma/prisma-engines#3461

But this looks like it's from prisma/prisma-engines#3456

The Test and release order on buildkite got inversed, which makes things a bit weird

Failures are the same for postgresql, sqlite and mariadb
https://github.com/prisma/prisma/actions/runs/3602199725/jobs/6068875549#step:10:894

  ● introspection: findMany on column_name_that_becomes_empty_string

    expect(received).toMatchSnapshot(hint)

    Snapshot name: `introspection: findMany on column_name_that_becomes_empty_string: warnings 1`

    - Snapshot  - 10
    + Received  +  0

    @@ -22,16 +22,6 @@
            },
          ],
          code: 3,
          message: These fields are not supported by the Prisma Client, because Prisma currently does not support their types.,
        },
    -   Object {
    -     affected: Array [
    -       Object {
    -         field: 12345,
    -         model: column_name_that_becomes_empty_string,
    -       },
    -     ],
    -     code: 2,
    -     message: These fields were commented out because their names are currently not supported by Prisma. Please provide valid ones that match [a-zA-Z][a-zA-Z0-9_]* using the `@map` attribute.,
    -   },
      ]

@Jolg42
Copy link
Member

Jolg42 commented Dec 2, 2022

I updated the snapshots to unblock the pipeline, but we should probably investigate and fix (pinged Tom and Julius on Slack)

…814c11f68346141127705831bc69857f0f7

# Conflicts:
#	packages/integration-tests/src/__tests__/integration/mariadb/__snapshots__/introspection.test.ts.snap
#	packages/integration-tests/src/__tests__/integration/postgresql/__snapshots__/introspection.test.ts.snap
#	packages/integration-tests/src/__tests__/integration/sqlite/__snapshots__/introspection.test.ts.snap
#	pnpm-lock.yaml
@Jolg42 Jolg42 merged commit 378d6f9 into main Dec 2, 2022
@Jolg42 Jolg42 deleted the deps/engines-4.8.0-6.b5a1e814c11f68346141127705831bc69857f0f7 branch December 2, 2022 15:20
Jolg42 added a commit that referenced this pull request Dec 5, 2022
Regression spotted in #16597 is fixed
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
…c69857f0f7 (#16597)

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
…c69857f0f7 (#16597)

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants