Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): fix tsc crashes with client extensions #16856

Merged
merged 2 commits into from Dec 19, 2022
Merged

fix(client): fix tsc crashes with client extensions #16856

merged 2 commits into from Dec 19, 2022

Conversation

millsp
Copy link
Member

@millsp millsp commented Dec 16, 2022 •
edited

Closes #16600
Closes #16536

@millsp millsp changed the base branch from main to test/local-ecosystem-tests December 16, 2022 00:44
@millsp millsp force-pushed the integration/fix/client-extensions-tsc-crash branch from c18ede7 to cdfa857 Compare December 16, 2022 00:52
@millsp millsp added this to the 4.8.0 milestone Dec 16, 2022
@millsp millsp changed the base branch from test/local-ecosystem-tests to main December 16, 2022 00:52
@millsp millsp marked this pull request as ready for review December 16, 2022 02:33
@millsp millsp requested review from a team, danstarns and SevInf and removed request for a team December 16, 2022 02:33
Jolg42
Jolg42 reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is empty, does a related issue/Slack conversation exists maybe? 👀

@millsp millsp linked an issue Dec 19, 2022 that may be closed by this pull request
$extends TS error: "Inferred type of this node exceeds the maximum length the compiler will serialize" with "declaration": true in tsconfig #16536
Closed
@millsp millsp removed a link to an issue Dec 19, 2022
$extends TS error: "Inferred type of this node exceeds the maximum length the compiler will serialize" with "declaration": true in tsconfig #16536
Closed
@millsp millsp merged commit 333f52a into main Dec 19, 2022
@millsp millsp deleted the integration/fix/client-extensions-tsc-crash branch December 19, 2022 17:50
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@millsp @jkomyno
fix(client): fix tsc crashes with client extensions (#16856)
7842063
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@millsp @jkomyno
fix(client): fix tsc crashes with client extensions (#16856)
50ce7f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 left review comments

@SevInf SevInf SevInf approved these changes

@danstarns danstarns Awaiting requested review from danstarns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.0
3 participants
@millsp @SevInf @Jolg42