-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): better errors for engine not found #19330
Merged
millsp
merged 27 commits into
main
from
integration/fix/client/unclear-engine-not-found-messages
May 25, 2023
Merged
fix(client): better errors for engine not found #19330
millsp
merged 27 commits into
main
from
integration/fix/client/unclear-engine-not-found-messages
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millsp
changed the title
fix(client): better errors for engine not found (library)
fix(client): better errors for engine not found
May 18, 2023
millsp
commented
May 18, 2023
millsp
commented
May 18, 2023
millsp
commented
May 18, 2023
millsp
commented
May 18, 2023
millsp
commented
May 18, 2023
jkomyno
reviewed
May 19, 2023
packages/client/src/runtime/core/engines/common/errors/weWouldAppreciateIfYouCouldShareInfo.ts
Show resolved
Hide resolved
jkomyno
reviewed
May 19, 2023
jkomyno
reviewed
May 19, 2023
.../src/runtime/core/engines/common/errors/engine-not-found/bundlerHasTamperedWithEngineCopy.ts
Outdated
Show resolved
Hide resolved
jkomyno
reviewed
May 19, 2023
...rc/runtime/core/engines/common/errors/engine-not-found/nativeGeneratedOnDifferentPlatform.ts
Outdated
Show resolved
Hide resolved
jkomyno
reviewed
May 19, 2023
packages/client/src/runtime/core/engines/common/resolveEnginePath.ts
Outdated
Show resolved
Hide resolved
jkomyno
reviewed
May 19, 2023
...nt/src/runtime/core/engines/common/errors/engine-not-found/theseLocationsHaveBeenSearched.ts
Show resolved
Hide resolved
jkomyno
reviewed
May 19, 2023
...es/client/tests/e2e/engine-not-found-error/binary-targets-incorrectly-pinned/tests/binary.ts
Show resolved
Hide resolved
jkomyno
reviewed
May 19, 2023
jkomyno
reviewed
May 19, 2023
SevInf
reviewed
May 22, 2023
...rc/runtime/core/engines/common/errors/engine-not-found/nativeGeneratedOnDifferentPlatform.ts
Outdated
Show resolved
Hide resolved
SevInf
reviewed
May 22, 2023
packages/client/src/runtime/core/engines/common/resolveEnginePath.ts
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
May 22, 2023
packages/client/src/__tests__/integration/errors/missing-engine/library.test.ts
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
May 22, 2023
Jolg42
reviewed
May 22, 2023
...es/client/tests/e2e/engine-not-found-error/binary-targets-incorrectly-pinned/tests/binary.ts
Show resolved
Hide resolved
Jolg42
approved these changes
May 24, 2023
SevInf
reviewed
May 24, 2023
packages/client/src/runtime/core/engines/common/resolveEnginePath.ts
Outdated
Show resolved
Hide resolved
SevInf
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small nit
…ath.ts Co-authored-by: Sergey Tatarintsev <tatarintsev@prisma.io>
millsp
deleted the
integration/fix/client/unclear-engine-not-found-messages
branch
May 25, 2023 03:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the current engine not found errors, which are not helpful for users, and not helpful for us to identify issues. Based on many issues related to engines not being found, we have come up with the following issue messages:
native
, if the actual platform at the time of generation and the platform obtained at runtime are not equal, append information to the error.Example error message:
binaryTargets
and without anynative
, and the actual platform obtained at runtime does not match anybinaryTargets
, append information to the error to explain that the targets were not pinned correctly.Example error message:
Example error message:
Example error message:
closes #7228
closes #16872
closes #15631
closes #15638
closes #17906
closes #17996
closes #7848
closes #15292
closes #13396
closes #13266
https://www.notion.so/prismaio/af44ea91e0904c0ab9f732145cac2d3f