Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): invalid $allModel trigger for raw query #19625

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

millsp
Copy link
Member

@millsp millsp commented Jun 5, 2023

@millsp millsp requested a review from a team as a code owner June 5, 2023 23:00
@millsp millsp requested review from SevInf and Druue and removed request for a team June 5, 2023 23:00
@millsp millsp added this to the 4.16.0 milestone Jun 5, 2023
@SevInf
Copy link
Contributor

SevInf commented Jun 7, 2023

I think new tests need a skip for Mongo, but otherwise LGTM

@millsp millsp force-pushed the fix/client/extension-query-trigger branch from e71fc63 to 5569afb Compare June 7, 2023 18:31
@millsp
Copy link
Member Author

millsp commented Jun 7, 2023

FYI: I changed this recently added test because it was invalid with this change. There is an issue to implement a top-level $allOperations.

https://github.com/prisma/prisma/pull/19625/files#diff-a22ee5e3a3ee441dedf6b4fea394ef2b3820c5a84a4df1cecf27bad0803c75ebL27

@millsp millsp merged commit e1069f8 into main Jun 7, 2023
67 of 68 checks passed
@millsp millsp deleted the fix/client/extension-query-trigger branch June 7, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCE: Query extensions of $queryRawUnsafe also triggers $allModels.$allOperations
2 participants