New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generators): Do not force install of package manager when using ni #19959
Conversation
...ls/src/get-generators/generatorResolvers/prisma-client-js/auto-installation/getPackageCmd.ts
Outdated
Show resolved
Hide resolved
Note: the |
@millsp is there any reason why this option it was not set to |
CodSpeed Performance ReportMerging #19959 Summary
Benchmarks breakdown
|
No I don't think there's any reason, it should always be marked as programmatic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I just reproduced and it works like expected, thanks for the PR!
npx prisma generate
Environment variables loaded from prisma/.env
Prisma schema loaded from prisma/schema.prisma
bun add v0.6.13 (3a93ddfa)
installed @prisma/client@4.17.0-dev.86
2 packages installed [343.00ms]
Removed: 1
✔ Installed the @prisma/client and prisma packages in your project
✔ Generated Prisma Client (4.17.0-dev.86 | library) to ./node_modules/@prisma/client in 45ms
You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client
...
Fixes #19945
When having a .lock file from a different package manager
ni
forces the installation or terminates the task if the user declines.To overcome this issue when
ni
is used in cli tools likeprisma cl
programmatic
should be set to true.