fix(client): intellisense type shapes #20319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #20319 will degrade performances by 30.98%Comparing Summary
Benchmarks breakdown
|
Jolg42
reviewed
Jul 21, 2023
Jolg42
approved these changes
Jul 21, 2023
ludralph
pushed a commit
that referenced
this pull request
Jul 25, 2023
jbranchaud
added a commit
to skillrecordings/products
that referenced
this pull request
Dec 28, 2023
https://github.com/prisma/prisma/releases/tag/5.2.0 Both the 5.1.0 and 5.2.0 upgrades didn't require any changes on our part. They both add improvements in performance by reducing unnecessary queries to the database. And 5.1.0 introduces better type resolution for intellisense (prisma/prisma#20319).
kodiakhq bot
pushed a commit
to skillrecordings/products
that referenced
this pull request
Jan 3, 2024
https://github.com/prisma/prisma/releases/tag/5.2.0 Both the 5.1.0 and 5.2.0 upgrades didn't require any changes on our part. They both add improvements in performance by reducing unnecessary queries to the database. And 5.1.0 introduces better type resolution for intellisense (prisma/prisma#20319).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of the
GetResultby forcing the evaluation of the types on the results. This cannot be tested easily because the types are purely equivalent and it's only a visual change in intellisense, so I left a comment in the code.Before:
After:
An unrelated PR about performance will get rid of the extra
& {}, so it will be easier to read than just the current fix. Keeping the PRs separate on purpose, although there's some overlap.closes #20320
closes https://github.com/prisma/team-orm/issues/228