fix: Ensure only selected types are exported from runime module #21119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #20161, in order to solve type declaration/OOM/performance issues, we added forced exports for every type within the runime. However, our type bundler renames certain types if the naming conflicts. For example, if there are 2 `Result` types, one of them will be renamed to `Result_2`. Making renamed type public gives `tsc` green light for dependenig on it when creating declaration for third-party library. This is wrong, because rename is not guaranteed to be stable. In fact, we have the problem with `accelerate` extension on a different branch: latest Accelerate depends on `Result_2`, but in a branch corresponding type got renamed to `Result_3`. Internal discussion: https://prisma-company.slack.com/archives/C04TW4A2H8C/p1694778678856899 In this PR we revert to manual re-exports and ensure every type from `core/types` gets re-exported without rename. Tests, fixed in #20161 are still green, but it also ensures that only types we want will leak to third party project. Couple of public types with conflicting names got renamed.
size-limit report 📦
|
|
Note: accelerate extension would need to be rebuilt to work correctly. We could add |
|
Superseded by #21179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20161, in order to solve type declaration/OOM/performance issues,
we added forced exports for every type within the runime.
However, our type bundler renames certain types if the naming conflicts.
For example, if there are 2
Resulttypes, one of them will be renamedto
Result_2.Making renamed type public gives
tscgreen light for dependenig on itwhen creating declaration for third-party library. This is wrong,
because rename is not guaranteed to be stable. In fact, we have the
problem with
accelerateextension on a different branch: latestAccelerate depends on
Result_2, but in a branch corresponding type gotrenamed to
Result_3.Internal discussion: https://prisma-company.slack.com/archives/C04TW4A2H8C/p1694778678856899
In this PR we revert to manual re-exports and ensure every type from
core/typesgets re-exported without rename. Tests, fixed in #20161 are still green,but it also ensures that only types we want will leak to third party
project.
Couple of public types with conflicting names got renamed.
/integration