Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): replace dynamic import for wasm-worker-loader with static export #23754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smorimoto
Copy link

@smorimoto smorimoto commented Apr 7, 2024

Fixes #23600

As I understand, since dynamic import is not necessary here, we can easily fix the linked issue.
Is there anything I am missing?
I'm actually using this patch in my runtime environment and I don't see any performance issues either.

@smorimoto smorimoto requested a review from a team as a code owner April 7, 2024 06:45
@smorimoto smorimoto requested review from Druue and removed request for a team April 7, 2024 06:45
@CLAassistant
Copy link

CLAassistant commented Apr 7, 2024

CLA assistant check
All committers have signed the CLA.

…tic export

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@jkomyno
Copy link
Contributor

jkomyno commented Apr 29, 2024

Thank you @smorimoto for this PR.
I think the next course of action for us is to merge this and observe the impact on our ecosystem-tests.

To summarise the context around this PR for other internal reviewers:

Copy link

@Vinlock Vinlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad this is getting fixed. Thank you 🙏🏼 🙏🏼 🙏🏼 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js app build fails when using Prisma with DB driver in Server Action
6 participants