Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): JSONB RSS usage #23917

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test(client): JSONB RSS usage #23917

wants to merge 2 commits into from

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Apr 22, 2024

tests #21471
Per @pzgorzaly's repro

Note: this doesn't preclude there being a leak in engines; this only measures js, so if anything, this further aids this suspicion

Running it at 1000 iterations:

No memory leak detected
Memory growth rate: 0.1799156039156039 bytes / iteration, which is below threshold

Running it at 500 iterations:

No memory leak detected
Memory growth rate: 0.3992183648734595 bytes / iteration, which is below threshold

Running it at 20 iterations:

No memory leak detected
Memory growth rate: 2.0210526315789474 bytes / iteration, which is below threshold

Copy link
Contributor

github-actions bot commented Apr 22, 2024

size-limit report 📦

Path Size
packages/client/runtime/library.js 179.64 KB (0%)
packages/client/runtime/library.d.ts 81 B (0%)
packages/client/runtime/binary.js 600.86 KB (0%)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 158.91 KB (0%)
packages/client/runtime/edge-esm.js 158.8 KB (0%)
packages/client/runtime/wasm.js 114.75 KB (0%)
packages/client/runtime/index-browser.js 33.77 KB (0%)
packages/client/runtime/index-browser.d.ts 89 B (0%)
packages/cli/build/index.js 2.77 MB (0%)
packages/client/prisma-client-0.0.0.tgz 3 MB (0%)
packages/cli/prisma-0.0.0.tgz 3.97 MB (0%)
packages/bundle-size/da-workers-libsql/output.tgz 880.81 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 959.65 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 978.38 KB (0%)
packages/bundle-size/da-workers-pg-worker/output.tgz 934.1 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 896.19 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 853.89 KB (0%)

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Client memory tests, node 18, library:

✅ Success

@Jolg42
Copy link
Member

Jolg42 commented Apr 24, 2024

@Druue Did you see this yet?
https://github.com/prisma/prisma/actions/runs/8785229177/job/24105290598?pr=23917#step:5:76

Running test rssJSONB
Prisma schema loaded from tests/memory/rssJSONB/prisma/schema.prisma
Datasource "db": PostgreSQL database "tests", schema "public" at "localhost:5432"

PostgreSQL database tests created at localhost:5432

The PostgreSQL database "tests" schema "public" at "localhost:5432" was successfully reset.

🚀  Your database is now in sync with your Prisma schema. Done in 26ms
Looks like test is leaking memory

Leak rate: 4484.509090909091 bytes / iteration

@Jolg42
Copy link
Member

Jolg42 commented Apr 25, 2024

It looks like the test is now passing with your last commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants