improv(client): Return JsonValue type #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sytten
reviewed
May 29, 2020
| @@ -157,7 +157,7 @@ declare interface JsonArray extends Array<JsonValue> {} | |||
| * From https://github.com/sindresorhus/type-fest/ | |||
| * Matches any valid JSON value. | |||
| */ | |||
| declare type JsonValue = string | number | boolean | null | JsonObject | JsonArray | |||
| declare type JsonValue = string | number | boolean | null | Date | JsonObject | JsonArray | |||
There was a problem hiding this comment.
Do you guys convert Dates? Its not a JSON primitive.
There was a problem hiding this comment.
I mention this here as well prisma/prisma-client-js#691 but this breaks the JSON specification. It gives TypeScript errors when trying to send the value through an API that encodes/decodes to JSON like Next.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related prisma/prisma-client-js#691