fix(client): delete transactionId field in middleware #7662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Available as |
Jolg42
reviewed
Jun 15, 2021
Comment on lines
+946
to
+947
| // TODO remove this, because transactionId should be passed? | ||
| if (index > 0) delete changedInternalParams['transactionId'] |
There was a problem hiding this comment.
We will need to remove this, because middlewares with transactions makes it not to be executed as a regular transaction (removes transactionId)
There was a problem hiding this comment.
Can we make an issue out of this so we can remember and prioritize? Thanks.
There was a problem hiding this comment.
This is preventing the transactions from rolling back. If enabled, transactions do rollback, but introduce those bugs we've seen on studio. I'm keeping track of this here #6705 (comment)
Jolg42
changed the title
|
Can confirm that the version Jan quoted fixes Studio! |
Jolg42
reviewed
Jun 15, 2021
Jolg42
approved these changes
Jun 15, 2021
williamluke4
approved these changes
Jun 15, 2021
Jolg42
added a commit
that referenced
this pull request
Jun 17, 2021
…gets * master: (69 commits) chore: remove unused printDatamodelDiff (#7686) chore: upgrade pnpm from v5 to v6 (#7685) chore(deps): update devdependencies (non-major) (#7636) chore(deps): update react-prisma (#7637) fix(client): delete transactionId field in middleware (#7662) fix(client): env-var loading (#7669) fix(client): ensure autoinstall looks for the correct client (#7670) fix(seed): add empty export {} for TypeScript --isolatedModules (#7666) fix(migrate): cleanup datasource printing for SQLServer & default to postgres for pg (#7654) fix(cli): remove --provider from init for now (#7667) fix(migrate): Make phrasing of migrate warning messages more accurate (#7664) fix(deps): update engines to v2.25.0-36.c838e79f39885bc8e1611849b1eb28b5bb5bc922 (#7649) chore(deps): update dependency @prisma/studio-server to v0.400.0 (#7645) fix(deps): update engines to v2.25.0-35.ec38a348006215c00435291bf23ddf6096ecccb9 (#7647) fix: disable Node-API with M1 (#7601) fix(deps): update engines to v2.25.0-30.149261944d529dc4c506db7e017bb4dfd26ef398 (#7623) fix(deps): update engines to v2.25.0-29.6d6abdeb152d51c75fcf8ab498150c5a6a79d805 (#7619) refactor(migrate): Simplify engine API of evaluateDataLoss in Migrate (#7576) ci: fix detect-jobs-to-run (#7616) fix(deps): update engines to v2.25.0-28.2456c6fa85cf119868d31902130d1c8401345c53 (#7572) ... # Conflicts: # src/packages/cli/package.json # src/packages/client/package.json # src/packages/engine-core/package.json # src/packages/fetch-engine/package.json # src/packages/migrate/package.json # src/packages/sdk/package.json # src/pnpm-lock.yaml
Andrew-Colman
pushed a commit
to Andrew-Colman/prisma
that referenced
this pull request
Aug 7, 2021
Co-authored-by: William Luke <william@ordino.ai> Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7584
https://github.com/prisma/e2e-tests/actions/runs/937511350