chore(sdk): split up engineCommands tests
#7829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follows #7796 |
|
@williamluke4 Looks like it's failing since the other PR was merged? |
williamluke4
force-pushed
the
test/split/engineCommands
branch
from
31ca0b9
to
7cb9a9a
Compare
williamluke4
force-pushed
the
test/split/engineCommands
branch
from
0c95c7e
to
a5f192f
Compare
Jolg42
reviewed
Jun 24, 2021
Comment on lines
+22
to
+48
| test('sqlite and createMany', async () => { | ||
| expect.assertions(1) | ||
| try { | ||
| await getConfig({ | ||
| datamodel: ` | ||
| datasource db { | ||
| provider = "sqlite" | ||
| url = "file:../hello.db" | ||
| } | ||
|
|
||
| generator client { | ||
| provider = "prisma-client-js" | ||
| previewFeatures = ["createMany"] | ||
| } | ||
|
|
||
| model A { | ||
| id Int @id | ||
| name String | ||
| }`, | ||
| }) | ||
| } catch (e) { | ||
| expect(stripAnsi(e.message)).toMatchInlineSnapshot(` | ||
| "Get config: Database provider \\"sqlite\\" and the preview feature \\"createMany\\" can't be used at the same time. | ||
| Please either remove the \\"createMany\\" feature flag or use any other database type that Prisma supports: postgres, mysql or sqlserver." | ||
| `) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Related for info:
createMany is GA since 2.20.0 and doesn't need a preview flag anymore.
We probably can remove this error?
prisma/src/packages/sdk/src/engine-commands/getConfig.ts
Lines 54 to 62 in 5a4d80c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.