fix(db push): make sure to stop migrate engine when it errors #8149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
requested changes
Jul 7, 2021
|
If you can't reproduce this locally, let me know. Good catch @janpio, I got fooled by the grey cancel icon. I'll pay more attention next time 👍 |
|
Ok I'll merge main later and see what this is about |
|
That's the danger of the timeouts I think - they cancel the job, and do not fail it by default. |
|
Yes... but better that it times out after 10 minutes than 6 hours by default 😄 |
Andrew-Colman
pushed a commit
to Andrew-Colman/prisma
that referenced
this pull request
Aug 7, 2021
…#8149) * fix(db push): make sure to stop migrate engine when it errors Related prisma#7795 prisma#7990 * Restore package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
#7795
#7990
Thanks @millsp for finding the test that uncovered this 👍🏼