feat(client): interactive transactions #8384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong-running-transactions
…ong-running-transactions
millsp
changed the title
millsp
force-pushed
the
feat/long-running-transactions
branch
2 times, most recently
from
ea0c578
to
1d7d5da
Compare
millsp
changed the title
…ong-running-transactions
…g-running-transactions
Jolg42
reviewed
Aug 9, 2021
Jolg42
reviewed
Aug 9, 2021
packages/client/src/__tests__/integration/happy/interactive-transactions/test.ts
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
Aug 9, 2021
| headers: string, | ||
| transactionId?: string, | ||
| ): Promise<string> | ||
| sdlSchema(): Promise<string> |
There was a problem hiding this comment.
There was a problem hiding this comment.
Can't remember, I'll have to ask Julius
There was a problem hiding this comment.
We can take care of this this in a separate PR
Jolg42
reviewed
Aug 9, 2021
Jolg42
reviewed
Aug 9, 2021
Jolg42
reviewed
Aug 9, 2021
Jolg42
reviewed
Aug 9, 2021
Jolg42
reviewed
Aug 9, 2021
Jolg42
reviewed
Aug 9, 2021
williamluke4
approved these changes
Aug 9, 2021
Jolg42
reviewed
Aug 9, 2021
Comment on lines
+125
to
+127
| get<R>(path: string, headers?: Client.DispatchOptions['headers']) { | ||
| return this.raw<R>('GET', path, headers) | ||
| } |
There was a problem hiding this comment.
Suggested change
| get<R>(path: string, headers?: Client.DispatchOptions['headers']) { | |
| return this.raw<R>('GET', path, headers) | |
| } | |
| get<R>(endpoint: string, headers?: Client.DispatchOptions['headers']) { | |
| return this.raw<R>('GET', endpoint, headers) | |
| } |
to make it consistent with POST
Jolg42
reviewed
Aug 9, 2021
| ): Promise<{ data: T; elapsed: number }> | ||
| requestBatch<T>( | ||
| headers?: QueryEngineRequestHeaders, | ||
| numTry?: number, |
There was a problem hiding this comment.
I thought numTry was not used from last deep dive, is it used anywhere?
There was a problem hiding this comment.
(We can do that in a separate PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1844
closes #7956
closes #7786
closes #7399
closes #6705
closes #7326
Internal doc