Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build, types): cleanup #8472

Closed
wants to merge 29 commits into from
Closed

chore(build, types): cleanup #8472

wants to merge 29 commits into from

Conversation

millsp
Copy link
Member

@millsp millsp commented Jul 28, 2021 •
edited

With this PR, we can now re-compile the whole project in ~2 seconds with pnpm run -r dev and follow types to their source without landing on dist types. The compilation is now fully handled by esbuild.

millsp added 16 commits July 26, 2021 22:26
@millsp millsp added this to the 2.29.0 milestone Jul 29, 2021
@millsp millsp self-assigned this Jul 29, 2021
@millsp
Copy link
Member Author

millsp commented Jul 29, 2021 •
edited

Test failing after esbuild + engine-core, switching to esbuild somehow changed the message

@millsp millsp changed the title chore(client, build): cleanup chore(client, build, types): cleanup Jul 29, 2021
@millsp millsp linked an issue Jul 29, 2021 that may be closed by this pull request
Enable Type Discovery #8443
Closed
9 tasks
@millsp millsp marked this pull request as ready for review July 29, 2021 05:18
@millsp millsp requested a review from Ekima July 29, 2021 05:19
Jolg42
Jolg42 reviewed Jul 29, 2021
View reviewed changes
tsconfig.json Show resolved Hide resolved
Jolg42
Jolg42 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Can't wait to try it locally!

@millsp millsp changed the title chore(client, build, types): cleanup chore(build, types): cleanup Jul 29, 2021
@millsp
Copy link
Member Author

millsp commented Jul 30, 2021

closed in favor of #8497

@millsp millsp closed this Jul 30, 2021
@Jolg42 Jolg42 deleted the fix/type-discovery branch August 3, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@williamluke4 williamluke4 Awaiting requested review from williamluke4

@Ekima Ekima Awaiting requested review from Ekima

Assignees

@millsp millsp

Labels
None yet
Projects
None yet
Milestone
2.29.0
Development

Successfully merging this pull request may close these issues.

Enable Type Discovery
2 participants
@millsp @Jolg42