Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): test getConfig provider array fix #8529

Closed
wants to merge 3 commits into from

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Aug 2, 2021

Related #8467

src/packages/cli/src/bin.ts Outdated Show resolved Hide resolved
try {
const schema = await getSchema(args['--schema'])
const config = await getConfig({
datamodel: schema,
ignoreEnvVarErrors: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we forgot to so that a long time ago, without it was throwing when env var was not set for example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #8529

* master:
  fix(db pull): only output schema to stdout when using --print (#8551)
  chore(deps): update engines to 2.29.0-12.8b139c140bd01ba4dd6c98f44a1edac48baa58e2 (#8552)
  ci: fix publish
  ci: debug publish
  ci: prepare for major bump (#8240)
  Update update-studio-version.yml
  fix(migrate): db push after reset if unexecutable step (#8540)
  chore(deps): update engines to 2.29.0-10.e60a94c3a98104c76460aa8ab556c33fab0e3781 (#8545)
  chore(deps): update engines to 2.29.0-9.b0d6f0c282944bba506eed792838c02fdbdab0f8 (#8542)
  chore(deps): update engines to 2.29.0-7.10fbb58853d626be41afb2930e56e0a36afefb9f (#8538)
  chore: disable migrate logging
  feat(migrate): Allow migration engine to log to stdout (#7896)
  chore: pin dependencies (#8534)
  chore(deps): update engines to 2.29.0-5.8062e306decdf2fe2c2dcb8409c513a2023c8653 (#8533)
  chore(deps): update fkirc/skip-duplicate-actions action to v3.4.1 (#8528)
  chore: move buildkite folder + fix publish (#8531)
  chore(prisma): type discovery + fast builds + clean monorepo (#8497)
@Jolg42
Copy link
Member Author

Jolg42 commented Aug 4, 2021

Fix was made in engines, closing
#8467 (comment)

@Jolg42 Jolg42 closed this Aug 4, 2021
@Jolg42 Jolg42 deleted the pr/test-getConfig-provider-array-fix branch August 4, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant