Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client, debug): query catch & debug types #8706

Closed
wants to merge 15 commits into from
Closed

fix(client, debug): query catch & debug types #8706

wants to merge 15 commits into from

Conversation

millsp
Copy link
Member

@millsp millsp commented Aug 12, 2021 •
edited

janpio and others added 11 commits August 10, 2021 18:34
@millsp millsp marked this pull request as ready for review August 12, 2021 03:44
@millsp millsp requested a review from Jolg42 August 12, 2021 03:45
@Jolg42
Copy link
Member

Jolg42 commented Aug 12, 2021 •
edited

Note: It would have been better I think to separate in multiple PR

It seems this PR has changes:

  • fixing the catch finally execution on model queries
  • debug type
  • and something not mentioned in the description, changes about transaction

@millsp Can you detail the changes about transaction?

  • Is it worth including in this patch?
  • Is it fixing something?

@williamluke4
fix(engine-core): MaxListenersExceededWarning and adds too many engin…
a674c38 
…es warning (#8712)

* fix(engine-core): MaxListenersExceededWarning and adds warning for too many engines

* test too many engines with node-api
janpio
janpio requested changes Aug 12, 2021
View reviewed changes
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate PRs please, with GitHub issues for all issues so we can track what was wrong and what fixed what.

prisma-bot and others added 2 commits August 12, 2021 12:52
@janpio janpio added this to the 2.30.0 milestone Aug 12, 2021
@Jolg42 Jolg42 changed the base branch from main to 2.29.x August 12, 2021 14:51
@millsp millsp closed this Aug 12, 2021
@millsp millsp deleted the fix/debug-types-and-query-catch branch August 12, 2021 15:57
@Jolg42
Copy link
Member

Jolg42 commented Aug 13, 2021

Replaced by #8720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio requested changes

@williamluke4 williamluke4 Awaiting requested review from williamluke4

@Jolg42 Jolg42 Awaiting requested review from Jolg42 Jolg42 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.30.0
6 participants
@millsp @Jolg42 @janpio @renovate-bot @williamluke4 @prisma-bot