chore(cli): add deprecation message for introspect command #8763

Jolg42 · 2021-08-16T09:54:58Z

Renamed to prisma db pull

added test for the warning
removed the really not nice test.sh and converted tests to Jest
moved some tests to a commands folder like packages/cli/src/__tests__/commands/Studio.test.ts

Renamed to `prisma db pull`

packages/cli/src/Studio.ts

…ed' of github.com:prisma/prisma into pr/introspect-deprecated * 'pr/introspect-deprecated' of github.com:prisma/prisma: Update packages/cli/src/Studio.ts Update packages/cli/src/Studio.ts * 'pr/introspect-deprecated' of github.com:prisma/prisma: Update packages/cli/src/Studio.ts Update packages/cli/src/Studio.ts

millsp · 2021-08-17T21:50:22Z

packages/cli/src/__tests__/commands/Generate.test.ts

-            const prisma = new PrismaClient()
-            \`\`\`
-          `)
+✔ Generated Prisma Client (0.0.0) to ./subdirectory/@prisma/client in XXms


I'm not sure why the the indentation changed

One mysterious thing for me with Jest ...

millsp · 2021-08-17T21:53:14Z

packages/cli/src/__tests__/fixtures/custom-generator/prisma/schema.prisma

@@ -0,0 +1,34 @@
+generator min {
+  // https://github.com/timsuchanek/minimal-generator
+  provider = "npx @timsuchanek/minimal-generator"


How does this work?

It runs the command, it's what powers the go client like https://github.com/prisma/prisma-client-go/blob/master/docs/quickstart.md

generator db { provider = "go run github.com/prisma/prisma-client-go" }

Source code should be here

prisma/packages/generator-helper/src/GeneratorProcess.ts

Lines 48 to 66 in f731467

if (this.isNode) {

this.child = fork(this.executablePath, [], {

stdio: ['pipe', 'inherit', 'pipe', 'ipc'],

env: {

...process.env,

PRISMA_GENERATOR_INVOCATION: 'true',

},

execArgv: ['--max-old-space-size=8096'],

})

} else {

this.child = spawn(this.executablePath, {

stdio: ['pipe', 'inherit', 'pipe'],

env: {

...process.env,

PRISMA_GENERATOR_INVOCATION: 'true',

},

shell: true,

})

}

packages/cli/src/CLI.ts

packages/cli/src/__tests__/commands/CLI.test.ts

* main: chore(deps): update engines to 2.30.0-15.4da3a4b94c0bc4080d9bca0c9af0ed6835b11a68 (#8800) chore(deps): update engines to 2.30.0-14.bc8ecb93b05fdd02e398f68b1ec6f66df813b1c6 (#8798) ci: switch engine type for both cli and client for relavant tests (#8782) fix(deps): update dependencies (non-major) (#8793) chore(deps): update react-prisma chore(deps): update engines to 2.30.0-13.9bcc8544c6e8000eadc8afce064b55d00b56ce28 (#8794) chore(deps): update jest (#8791) chore(deps): update devdependencies (non-major) (#8790) chore(deps): update engines to 2.30.0-12.bea9c1f215004e5407a7c5f77287b8bd5a24ea3c (#8785) chore(deps): update engines to 2.30.0-11.efdfe2be6801d76e59e7488f5bc60cece4e366d9 (#8780) chore(deps): update dependency @prisma/studio-server to v0.421.0 (#8767) chore(deps): update engines to 2.30.0-10.0210b3de5042a714f8838a59f9edcb28b11ab97d (#8778) chore(deps): update engines to 2.30.0-9.a8608ff20d8774e88657834d2d58ad4c9134e5b7 (#8769) chore: remove encrypt=DANGER_PLAINTEXT (#8737)

janpio · 2021-08-18T18:31:00Z

packages/cli/fixtures/test.sh

@@ -1,134 +0,0 @@
-#!/bin/bash


Sure this file should go away? Did these tests move somewhere else?

They've been ported to src/__tests__/commands/Generate.test.ts

millsp · 2021-08-18T22:14:26Z

Approved ✔️ Nice to see some cleanup along your PR. Thanks!

chore(cli): add deprecation message for introspect command

65f4914

Renamed to `prisma db pull`

Jolg42 added this to the 2.30.0 milestone Aug 16, 2021

Jolg42 added 7 commits August 16, 2021 15:45

chore(cli): move commands into their own directory

f74b4c0

test(cli): remove test.sh and port to Jest

230bdb4

fix Version.ts

c31ad64

test(cli): normalize snapshots

0d1ec9b

fix generate

c3a7a26

move commands ts files

832a529

revert changes

666915f

Jolg42 commented Aug 16, 2021

View reviewed changes

packages/cli/src/Studio.ts Outdated Show resolved Hide resolved

Update packages/cli/src/Studio.ts

c2bb5cc

Jolg42 commented Aug 16, 2021

View reviewed changes

packages/cli/src/Studio.ts Outdated Show resolved Hide resolved

Jolg42 and others added 4 commits August 16, 2021 17:57

Update packages/cli/src/Studio.ts

cf91c95

add missing schema

e58502b

test(cli): test CLI warning for introspect

f731467

Jolg42 marked this pull request as ready for review August 17, 2021 07:27

Jolg42 requested review from millsp and williamluke4 as code owners August 17, 2021 07:27

millsp reviewed Aug 17, 2021

View reviewed changes

Jolg42 commented Aug 18, 2021

View reviewed changes

packages/cli/src/CLI.ts Outdated Show resolved Hide resolved

Jolg42 commented Aug 18, 2021

View reviewed changes

packages/cli/src/__tests__/commands/CLI.test.ts Outdated Show resolved Hide resolved

Jolg42 and others added 3 commits August 18, 2021 18:30

Apply suggestions from code review

7dd6801

test: update snapshot

31ec318

Jolg42 merged commit 2bce15b into main Aug 18, 2021

Jolg42 deleted the pr/introspect-deprecated branch August 18, 2021 17:23

janpio reviewed Aug 18, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(cli): add deprecation message for introspect command #8763

chore(cli): add deprecation message for introspect command #8763

Jolg42 commented Aug 16, 2021 •

edited

millsp Aug 17, 2021

Jolg42 Aug 18, 2021

millsp Aug 17, 2021

Jolg42 Aug 18, 2021

Jolg42 Aug 18, 2021

janpio Aug 18, 2021

millsp Aug 18, 2021

millsp commented Aug 18, 2021 •

edited

	if (this.isNode) {
	this.child = fork(this.executablePath, [], {
	stdio: ['pipe', 'inherit', 'pipe', 'ipc'],
	env: {
	...process.env,
	PRISMA_GENERATOR_INVOCATION: 'true',
	},
	execArgv: ['--max-old-space-size=8096'],
	})
	} else {
	this.child = spawn(this.executablePath, {
	stdio: ['pipe', 'inherit', 'pipe'],
	env: {
	...process.env,
	PRISMA_GENERATOR_INVOCATION: 'true',
	},
	shell: true,
	})
	}

chore(cli): add deprecation message for introspect command #8763

chore(cli): add deprecation message for introspect command #8763

Conversation

Jolg42 commented Aug 16, 2021 • edited

millsp Aug 17, 2021

Choose a reason for hiding this comment

Jolg42 Aug 18, 2021

Choose a reason for hiding this comment

millsp Aug 17, 2021

Choose a reason for hiding this comment

Jolg42 Aug 18, 2021

Choose a reason for hiding this comment

Jolg42 Aug 18, 2021

Choose a reason for hiding this comment

janpio Aug 18, 2021

Choose a reason for hiding this comment

millsp Aug 18, 2021

Choose a reason for hiding this comment

millsp commented Aug 18, 2021 • edited

Jolg42 commented Aug 16, 2021 •

edited

millsp commented Aug 18, 2021 •

edited