This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Enabling statement cache for PostgreSQL #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
approved these changes
Jun 17, 2020
src/connector/postgres.rs
Outdated
| @@ -226,6 +236,7 @@ impl PostgresUrl { | |||
| let mut socket_timeout = None; | |||
| let mut connect_timeout = None; | |||
| let mut pg_bouncer = false; | |||
| let mut statement_cache_size = 0; | |||
There was a problem hiding this comment.
We'll probably figure things out as we start using it, but for other quaint users, if it works we may want to default to a non-zero size.
There was a problem hiding this comment.
I don't want to enable this to everybody by default. Should be opt-in.
There was a problem hiding this comment.
There's no other way to reuse prepared statements currently, so this should at least to be well documented.
There was a problem hiding this comment.
Ok. Making the default here to 500. Let's see...
pimeys
pushed a commit
to prisma/prisma-engines
that referenced
this pull request
Jun 19, 2020
- Quaint PR: prisma/quaint#143 - Issue: prisma/prisma#2720
pimeys
pushed a commit
to prisma/prisma-engines
that referenced
this pull request
Jun 19, 2020
- Quaint PR: prisma/quaint#143 - Issue: prisma/prisma#2720
pimeys
pushed a commit
to prisma/prisma-engines
that referenced
this pull request
Jun 19, 2020
* Caching postgres statements * Enabling statement caching for PostgreSQL - Quaint PR: prisma/quaint#143 - Issue: prisma/prisma#2720 * Disabling statement caching on ME
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter
statement_cache_sizeto enable statement caching for PostgreSQL. By default 0, meaning no cache. Ifpgbouncerflag is on, cache will be disabled.issue: prisma/prisma#2720