This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix(sqlite): float columns should return floats #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weakky
changed the title
Weakky
commented
Jun 20, 2022
| @@ -5,7 +5,7 @@ use super::{Column, Table}; | |||
| /// Used mainly for the transformation of a `INSERT` into a `MERGE`. | |||
| #[derive(Debug, PartialEq, Clone)] | |||
| pub enum IndexDefinition<'a> { | |||
| Single(Column<'a>), | |||
| Single(Box<Column<'a>>), | |||
There was a problem hiding this comment.
Weakky
commented
Jun 20, 2022
| @@ -1 +1 @@ | |||
| 1.56.0 | |||
| 1.57.0 | |||
There was a problem hiding this comment.
required by some dependency ; check the previous commit test failure if you need more info
cprieto
approved these changes
Jun 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes prisma/prisma-engines#2991
Float columns on SQLite are migrated as
REAL. However,REALcolumns were coerced asBigDecimalwhich are then coerced asDecimalJS side.We're now only treating
DecimalasBigDecimal, thus keepingFloatcolumns asFloat.