ci: run type tests against various TypeScript version #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
angeloashmore
approved these changes
Jan 23, 2023
.github/workflows/ci.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| node: [14] |
There was a problem hiding this comment.
Any thoughts on including Node.js 18 in this list? Node 18 is unique since it introduces Web APIs that could affect our libraries, including fetch, Response, and Blob.
.github/workflows/ci.yml
Outdated
| key: ${{ matrix.os }}-node-v${{ matrix.node }}-deps-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }} | ||
|
|
||
| - name: Overwrite TypeScript | ||
| run: npm install --save-dev typescript@${{ matrix.typescript }} |
There was a problem hiding this comment.
Is the --save-dev necessary? Modifying the package-lock.json makes the workflow less pure since it modifies the code its testing.
We could use --no-save to only install TypeScript without modifying the repo.
(If you think changing package-lock.json doesn't make a difference, we can keep it as is.)
|
Alright
I'll merge it now, but if you have any additional comments feel free to voice them :) |
|
No comments — looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR runs type tests across various version of TypeScript (4.5 through 4.9).
It fixes the few errors pointed out by those new tests.
@ts-ignoreinstead of@ts-expect-errorfor a specific TypeScript 4.9 issue (not sure about it, but apparently in keyword can't be used on a narrowed down expression with a nullable generic constraint microsoft/TypeScript#51501 got fixed on the upcoming 5.0 version, someone suggested to backport it to 4.9 but for now it has been ignored)This PR also refactors a bit the CI architecture to accommodate those new tests. It's a bit more complex but about as fast when not running
size-limitand faster when running it.Resolves: #274
Checklist: