feat: support yarn pnp

[JounQin]

close #26
close import-js/eslint-import-resolver-typescript#130

continue #27

I'll try to add a test case later, and it has been confirmed to be working as expected at https://github.com/import-js/eslint-import-resolver-typescript/pull/133 by `yarn patch`.

[JounQin]

@privatenumber I don't know whether my latest commit 1febc92 (#28) a correct/good test case, it runs tests with PnP and tests without PnP, please help to review, or I can revert that commit and leave the test case for you?

[JounQin]

Friendly ping @privatenumber

[privatenumber]

Let's revert any unnecessary changes that has nothing to do with yarn/pnp.

[JounQin]

Let's revert any unnecessary changes that has nothing to do with yarn/pnp.

They're all required changes.

[privatenumber]

Why is this required?

[JounQin]

Why is this required?

It's fixed by ESLint.

eslint-plugin-import seems not working well with yarn PnP.

See also import-js/eslint-plugin-import#2487 (comment)

[privatenumber]

We can't move forward with this if it's unpredictably changing the way ESLint behaves.

[JounQin]

We can't move forward with this if it's unpredictably changing the way ESLint behaves.

So we test with yarn PnP, lint with npm, is this acceptable?

[privatenumber]

Ideally, using yarn should be isolated to running yarn/pnp tests. Best case, yarn's resolver is imported rather than injected by running via yarn.

[JounQin]

Ideally, using yarn should be isolated to running yarn/pnp tests. Best case, yarn's resolver is imported rather than injected by running via yarn.

I don't know how to implement it easily. 😅

Maybe you can try this way after merging?

I'll change to use npm run lint on CI.

[privatenumber]

There should also be a test-case that fails without these changes.

[JounQin]

There should also be a test-case that fails without these changes.

Not sure to understand, can you explain in details?

We have Test without PnP and Test with yarn PnP both.

---

All test cases are passing now, how do you think?

[privatenumber]

For all the tests that are running with pnp, a fixture with node_modules/dep/package.json is created, so it doesn't seem like it's testing pnp behavior.

To test the new feature, there should be a test case that fails prior to these changes, which passes after these changes.

[JounQin]

To test the new feature, there should be a test case that fails prior to these changes, which passes after these changes.

I don't know how to test to revert these changes first? I believe you can add this test case later?

pnpm has PnP mode the same time, it also resolves node_modules deps and PnP both, (we're using this on CI, because tsx doesn't support yarn PnP natively for now).

[privatenumber]

I added a failing test here: #32

Can you pull it in?

[JounQin]

I added a failing test here: #32

Can you pull it in?

Let me check.

[privatenumber]

Thanks for the PR @JounQin. It's looking really good.

I was glad to see the feature implementation is working with pnp without a node_modules directory.

I haven't actually started reviewing the implementation yet but will take a look tomorrow.