-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support TS5 extends
array
#45
feat: support TS5 extends
array
#45
Conversation
Can you add tests? |
I added a test and upgraded TypeScript to 5.0 for testing. But it is causing a type error at the test because |
.vscode/settings.json
Outdated
"typescript.tsdk": "node_modules/typescript/lib", | ||
"editor.formatOnSave": false, | ||
"editor.formatOnPaste": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I eliminated this change from the commit tree.
@@ -25,7 +25,7 @@ function resolveFromPackageJsonPath(packageJsonPath: string) { | |||
); | |||
} | |||
|
|||
export function resolveExtends( | |||
export function resolveExtendsPath( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it because its name conflicted with the new function created. I don't have any idea of new naming of the function. Can you help it?
Co-authored-by: hiroki osame <hiroki.osame@gmail.com>
63c77fd
to
5dfd2c0
Compare
Will release after sindresorhus/type-fest#580 |
OK. Thank you for reviewing and refactoring! |
extends
extends
array
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Supports Multiple Configuration Files in
extends
, supported in TS 5.0.types-fest
does not yet support multiple files, but I have created a PR and will soon. 😉fix #44