fix: respect the same ignore setting passed to chokidar #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Regarding the failing test - I am not able to reproduce on my machine (Ubuntu 20). The
|
|
No worries, it's a flaky test. Will look at this more closely later, thanks for the PR. |
DesignByOnyx
force-pushed
the
221-watch-ignore-fix
branch
from
9dd8eaa
to
d5d6a52
Compare
DesignByOnyx
force-pushed
the
221-watch-ignore-fix
branch
from
d5d6a52
to
f73ca4d
Compare
|
Switching to |
|
I'm not sure if this actually fixes the problem you're describing in the issue. I'm skeptical if chokidar will watch a file that is configured to be ignored even if it's passed in. |
|
Please see my reply on the linked issue: #221 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #221.