fix(deps): -semver (#1893)

chore: remove semver as dependency

package.json

@@ -64,7 +64,6 @@
     "pino-http": "^5.3.0",
     "pkg-conf": "^3.1.0",
     "resolve": "^1.19.0",
-    "semver": "^7.3.4",
     "update-dotenv": "^1.1.1"
   },
   "devDependencies": {
@@ -77,7 +76,6 @@
     "@types/js-yaml": "^3.12.5",
     "@types/node": "^18.18.1",
     "@types/resolve": "^1.17.1",
-    "@types/semver": "^7.3.4",
     "@types/supertest": "^2.0.10",
     "body-parser": "^1.19.0",
     "bottleneck": "^2.19.5",

src/bin/probot.ts

@@ -1,11 +1,11 @@
-import semver from "semver";
 import program from "commander";
+import { isSupportedNodeVersion } from "../helpers/is-supported-node-version";
 
 require("dotenv").config();
 
 const pkg = require("../../package");
 
-if (!semver.satisfies(process.version, pkg.engines.node)) {
+if (!isSupportedNodeVersion()) {
   console.log(
     `Node.js version ${pkg.engines.node} is required. You have ${process.version}.`,
   );

src/helpers/is-supported-node-version.ts

@@ -0,0 +1,3 @@
+export function isSupportedNodeVersion(nodeVersion = process.versions.node) {
+  return Number(nodeVersion.split(".", 10)[0]) >= 18;
+}

test/bin/is-supported-node-version.test.ts

@@ -0,0 +1,21 @@
+import { isSupportedNodeVersion } from "../../src/helpers/is-supported-node-version";
+import { engines } from "../../package.json";
+
+describe("isSupportedNodeVersion", () => {
+  it(`engines value is set to ">=18"`, () => {
+    expect(engines.node).toBe(">=18");
+  });
+
+  it("returns true if node is bigger or equal v18", () => {
+    expect(isSupportedNodeVersion("18.0.0")).toBe(true);
+    expect(isSupportedNodeVersion("19.0.0")).toBe(true);
+    expect(isSupportedNodeVersion("20.0.0")).toBe(true);
+    expect(isSupportedNodeVersion("21.0.0")).toBe(true);
+  });
+
+  it("returns false if node is smaller than v18", () => {
+    expect(isSupportedNodeVersion("17.0.0")).toBe(false);
+    expect(isSupportedNodeVersion("17.9.0")).toBe(false);
+    expect(isSupportedNodeVersion("17.9.9")).toBe(false);
+  });
+});