fix: Move unhandled rejection listener to cli scripts (#339)

probot · Nov 21, 2017 · f8abe25 · f8abe25
1 parent 62e984c
commit f8abe25
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/bin/probot-simulate.js b/bin/probot-simulate.js
@@ -28,6 +28,7 @@ const probot = createProbot({
   id: program.app,
   cert: findPrivateKey()
 })
+
 probot.setup(program.args.slice(2))
 
 probot.logger.debug('Simulating event', eventName)

diff --git a/lib/index.js b/lib/index.js
@@ -28,9 +28,6 @@ const defaultApps = [
   require('./plugins/default')
 ]
 
-// Log all unhandled rejections
-process.on('unhandledRejection', logger.error.bind(logger))
-
 module.exports = (options = {}) => {
   const webhook = createWebhook({path: options.webhookPath || '/', secret: options.secret || 'development'})
   const app = createApp({
@@ -83,6 +80,10 @@ module.exports = (options = {}) => {
   }
 
   function setup (apps) {
+    // Log all unhandled rejections
+    process.on('unhandledRejection', logger.error.bind(logger))
+
+    // Load the given apps along with the default apps
     apps.concat(defaultApps).forEach(app => load(app))
   }