feat: update @octokit/webhooks to v9
#1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: remove '*' event BREAKING CHANGE: app.webhooks.middleware has been removed in `@octokit/webhooks` v9
This also makes it comply with the types expected from the `receive()` function from `@octokit/webhooks`
…foreEach()` in the webhooks test
BREAKING CHANGE: removes the `webhookPath` option on `new Probot({})` for the webhooks middleware
…iddleware.test.ts`
…ally a breaking change, if the `x-hub-signature-256` header is not present, the `webhooks.onError()` callback is not called, because it does not even get that far. But I do not think that it is worth mentioning
…les`, add direct dependency to `@octokit/webhooks-types`
… to represent" error
gr2m
commented
Jun 19, 2021
| WebhookExamples.filter( | ||
| (event) => event.name === "pull_request" | ||
| )[0] as WebhookDefinition<"pull_request"> | ||
| ).examples[0]; |
There was a problem hiding this comment.
these are unrelated style changes
|
The TypeScript errors when building are gone via 1d49aa1, do you see any problems in the changes? @wolfy1339 I tested it locally and IntelliSense seems to be working as expected The errors are now signature mismatch errors |
|
The signature mismatch errors should be gone with the new update of |
wolfy1339
reviewed
Jun 22, 2021
wolfy1339
reviewed
Jun 22, 2021
All seems good for that change. |
|
I found some usages of the diff --git a/test/run.test.ts b/test/run.test.ts
index 941ac54..6610278 100644
--- a/test/run.test.ts
+++ b/test/run.test.ts
@@ -80,10 +80,11 @@ describe("run", () => {
});
describe("webhooks", () => {
+ const pushEvent = require("./fixtures/webhook/push.json");
it("POST /", async () => {
server = await run(() => {}, { env });
- const dataString = require("./fixtures/webhook/push.json");
+ const dataString = JSON.stringify(pushEvent);
await request(server.expressApp)
.post("/")
@@ -105,7 +106,7 @@ describe("run", () => {
},
});
- const dataString = require("./fixtures/webhook/push.json");
+ const dataString = JSON.stringify(pushEvent);
await request(server.expressApp)
.post("/custom-webhook") |
|
This is ready to go now from my side @wolfy1339.
|
This comment has been minimized.
This comment has been minimized.
|
LGTM 👍 |
|
🎉 This PR is included in version 12.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
added a commit
that referenced
this pull request
Jun 24, 2021
BREAKING CHANGE: remove '*' event
BREAKING CHANGE: app.webhooks.middleware has been removed in `@octokit/webhooks` v9
BREAKING CHANGE: removes the `webhookPath` option on `new Probot({})` for the webhooks middleware
Co-authored-by: wolfy1339 <webmaster@wolfy1339.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #1481