Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update @octokit/webhooks to v9 #1559

Merged
merged 35 commits into from Jun 23, 2021
Merged

feat: update @octokit/webhooks to v9 #1559

merged 35 commits into from Jun 23, 2021

Commits on Jun 18, 2021

  1. feat: upgrade to @octokit/webhooks v9 

    BREAKING CHANGE: remove '*' event
BREAKING CHANGE: app.webhooks.middleware has been removed in `@octokit/webhooks` v9
    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    1e6eb74 View commit details
    Browse the repository at this point in the history

  2. fix: remove path option when creating the Webhooks class

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    072e675 View commit details
    Browse the repository at this point in the history

  3. fix: use the new middleware from @octokit/webhooks

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    677bbad View commit details
    Browse the repository at this point in the history

  4. refactor(tests): simplify declaration of event 

    This also makes it comply with the types expected from the `receive()` function from `@octokit/webhooks`
    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    c59bbdc View commit details
    Browse the repository at this point in the history

  5. refactor(tests): move declaration of event variable to it's own `be… 

    …foreEach()` in the webhooks test
    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    8b576d8 View commit details
    Browse the repository at this point in the history

  6. tests: remove the * event

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    b6b2326 View commit details
    Browse the repository at this point in the history

  7. fix: remove wrapper around Webooks#on

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    663f619 View commit details
    Browse the repository at this point in the history

  8. fix: clean up imports in src/context.ts

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    dbec054 View commit details
    Browse the repository at this point in the history

  9. fix: update getErrorHandler() imports and typecasting

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    7502f94 View commit details
    Browse the repository at this point in the history

  10. lint: run prettier

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    2df7788 View commit details
    Browse the repository at this point in the history

  11. tests: fixups

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    b0fe0c2 View commit details
    Browse the repository at this point in the history

  12. build: bump @octokit/webhooks-examples

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    8d67e8a View commit details
    Browse the repository at this point in the history

  13. fix: comment out implement in Context for now

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    40b7645 View commit details
    Browse the repository at this point in the history

  14. fix: pass path down to the webhooks middleware

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    f020b6c View commit details
    Browse the repository at this point in the history

  15. fix: add missing parameter name to JSDoc comment

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    baa050d View commit details
    Browse the repository at this point in the history

  16. style: prettier

    @gr2m
    gr2m committed Jun 18, 2021
    Copy the full SHA
    c8ea489 View commit details
    Browse the repository at this point in the history

  17. test: fix context tests

    @gr2m
    gr2m committed Jun 18, 2021
    Copy the full SHA
    b9c545e View commit details
    Browse the repository at this point in the history

  18. fix: x-hub-signature-256 header is now required

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    19cd186 View commit details
    Browse the repository at this point in the history

  19. refactor: remove un-needed path option 

    BREAKING CHANGE: removes the `webhookPath` option on `new Probot({})` for the webhooks middleware
    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    ac66195 View commit details
    Browse the repository at this point in the history

  20. tests: change test name to reflect x-hub-signature-256 requirement

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    e4aea01 View commit details
    Browse the repository at this point in the history

  21. feat: introduce new webhooksPath option for the middleware

    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    de6c747 View commit details
    Browse the repository at this point in the history

  22. test: remove unhandled promise rejection error in `test/create-node-m… 

    …iddleware.test.ts`
    @gr2m
    gr2m committed Jun 18, 2021
    Copy the full SHA
    b70c486 View commit details
    Browse the repository at this point in the history

  23. test: adapt server test for latest @octokit/webhooks. It is techinc… 

    …ally a breaking change, if the `x-hub-signature-256` header is not present, the `webhooks.onError()` callback is not called, because it does not even get that far. But I do not think that it is worth mentioning
    @gr2m
    gr2m committed Jun 18, 2021
    Copy the full SHA
    cf57401 View commit details
    Browse the repository at this point in the history

  24. build(package): lock file

    @gr2m
    gr2m committed Jun 18, 2021
    Copy the full SHA
    38e59e2 View commit details
    Browse the repository at this point in the history

  25. build(deps): Unpin @octokit/webhooks, bump `@octokit/webhooks-examp… 

    …les`, add direct dependency to `@octokit/webhooks-types`
    @wolfy1339 @gr2m
    wolfy1339 authored and gr2m committed Jun 18, 2021
    Copy the full SHA
    ff4a986 View commit details
    Browse the repository at this point in the history

  26. build(deps): bump @octokit/webhooks* packages to latest

    @gr2m
    gr2m committed Jun 18, 2021
    Copy the full SHA
    13b41cb View commit details
    Browse the repository at this point in the history

  27. build(package): lock file

    @gr2m
    gr2m committed Jun 18, 2021
    Copy the full SHA
    28144bc View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. WIP: workaround "Expression produces a union type that is too complex… 

    … to represent" error
    @gr2m
    gr2m committed Jun 19, 2021
    Copy the full SHA
    1d49aa1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. build(package): bump @octokit/webhooks to ^9.8.4

    @gr2m
    gr2m committed Jun 22, 2021
    Copy the full SHA
    ce64dd3 View commit details
    Browse the repository at this point in the history

  2. build(package): lock file

    @gr2m
    gr2m committed Jun 22, 2021
    Copy the full SHA
    49dfe2c View commit details
    Browse the repository at this point in the history

  3. style: prettier

    @gr2m
    gr2m committed Jun 22, 2021
    Copy the full SHA
    e46459c View commit details
    Browse the repository at this point in the history

  4. test: pass string payload body instead of object

    @gr2m
    gr2m committed Jun 22, 2021
    Copy the full SHA
    293e903 View commit details
    Browse the repository at this point in the history

  5. docs: add comment about new Webhooks<Context>({...})

    @gr2m
    gr2m committed Jun 22, 2021
    Copy the full SHA
    26574c9 View commit details
    Browse the repository at this point in the history

  6. test: skip run test that was skipped before

    @gr2m
    gr2m committed Jun 22, 2021
    Copy the full SHA
    5774187 View commit details
    Browse the repository at this point in the history

  7. fix: mount @octokit/webhooks middleware to the webhooks path option

    @gr2m
    gr2m committed Jun 22, 2021
    Copy the full SHA
    4070737 View commit details
    Browse the repository at this point in the history