Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀 docs: architecture #1453

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

馃毀 docs: architecture #1453

wants to merge 3 commits into from

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jan 3, 2021

Preview

probot architecture

Created with https://excalidraw.com/. You can open the probot-architecture.json file and edit it

Follow up to #1452 (comment) /cc @shaftoe

Note that @probot/server and @probot/app do not yet exist. They currently are both implemented in the probot core package, in src/server.ts and src/probot.ts. And Probot does not yet use @octokit/app. But that is the next step, so I thought I'll lay out where we want to go, and fill in the blanks for anyone who has questions until then.

@gr2m gr2m requested a review from a team as a code owner January 3, 2021 20:42
@request-info
Copy link

request-info bot commented Jan 3, 2021

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

SVG did not render correctly
@shaftoe
Copy link
Contributor

shaftoe commented Jan 4, 2021

Thanks for this, it helps already a lot to get started to have a look at the code base. I'll use this as reference now and see how far I can get while note down questions that will arise, then will ping back.

By the way, I don't know the effort needed to keep this document up to date but I believe it has true value for anybody else who wants to dig deeper into the project. On the other end, if not kept up to date, it might have the opposite effect, so probably we should make visible directly in the doc at least the API version is meant for.

@gr2m
Copy link
Contributor Author

gr2m commented Jan 4, 2021

By the way, I don't know the effort needed to keep this document up to date but I believe it has true value for anybody else who wants to dig deeper into the project. On the other end, if not kept up to date, it might have the opposite effect, so probably we should make visible directly in the doc at least the API version is meant for.

I want to add the diagram to the docs, together with instructions how to edit it. You can upload the static/architecture/probot-architecture.json file to https://excalidraw.com/ for editing

Excalidraw
Excalidraw is a whiteboard tool that lets you easily sketch diagrams that have a hand-drawn feel to them.

@stale
Copy link

stale bot commented May 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 10, 2021
@stale stale bot removed the wontfix label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants