-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(security): Set up code scanning #1882
Conversation
This sets up CodeQL to automatically detect possible security problems.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
It appears it only detected 3 instances of the same issue in tests. I'll create a separate PR to fix these for the beta branch. It's not a real vulnerability, so there's nothing important to fix here, but it's still good to have some automated monitoring. |
I think there is an option for making a "deep" scan. |
Not sure what you mean by deep scan? Do you mean the extended rules? https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#using-queries-in-ql-packs
|
yes. |
I was going to try the "simple" setup first, but we can probably really move to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 13.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This sets up CodeQL to automatically detect possible security problems.