Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(security): Set up code scanning #1882

Merged
merged 2 commits into from
Nov 12, 2023
Merged

ci(security): Set up code scanning #1882

merged 2 commits into from
Nov 12, 2023

Conversation

AaronDewes
Copy link
Member

This sets up CodeQL to automatically detect possible security problems.

This sets up CodeQL to automatically detect possible security problems.
@AaronDewes AaronDewes requested a review from a team as a code owner November 10, 2023 16:01
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@AaronDewes
Copy link
Member Author

It appears it only detected 3 instances of the same issue in tests. I'll create a separate PR to fix these for the beta branch. It's not a real vulnerability, so there's nothing important to fix here, but it's still good to have some automated monitoring.

@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 10, 2023

I think there is an option for making a "deep" scan.

@AaronDewes
Copy link
Member Author

AaronDewes commented Nov 10, 2023

I think there is an option for making a "deep" scan.

Not sure what you mean by deep scan? Do you mean the extended rules? https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#using-queries-in-ql-packs

GitHub Docs
You can customize how your advanced setup scans the code in your project for vulnerabilities and errors.

@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 10, 2023

yes. security-and-quality

@AaronDewes
Copy link
Member Author

I was going to try the "simple" setup first, but we can probably really move to that.

Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronDewes AaronDewes changed the title Set up code scanning ci(security): Set up code scanning Nov 10, 2023
@gr2m gr2m merged commit 4100b25 into beta Nov 12, 2023
10 checks passed
@gr2m gr2m deleted the codeql branch November 12, 2023 17:56
Copy link

🎉 This PR is included in version 13.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants