Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use import() instead of require to import smee-client #1889

Merged
merged 1 commit into from Nov 12, 2023

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Nov 11, 2023

I assume that using require in an esm environment could break.

@Uzlopak Uzlopak requested a review from a team as a code owner November 11, 2023 00:41
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@gr2m gr2m changed the title chore: use import() instead of require to import smee-client fix: use import() instead of require to import smee-client Nov 12, 2023
@gr2m gr2m merged commit 8999768 into probot:beta Nov 12, 2023
8 checks passed
Copy link

🎉 This PR is included in version 13.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Uzlopak Uzlopak deleted the import-smee-client branch November 30, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants