chore: avoid require to load package.json #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
force-pushed
the
improve-cov-manifest-creation
branch
2 times, most recently
from
12957cc
to
81cddd5
Compare
AaronDewes
reviewed
Nov 11, 2023
gr2m
reviewed
Nov 11, 2023
Uzlopak
force-pushed
the
improve-cov-manifest-creation
branch
2 times, most recently
from
f5c8fe5
to
d2608c1
Compare
Uzlopak
force-pushed
the
improve-cov-manifest-creation
branch
from
d2608c1
to
71e7d12
Compare
|
PTAL The new function has 100 % test coverage and is implemented as resilient as possible. |
gr2m
approved these changes
Nov 12, 2023
| ): { [key: string]: any } { | ||
| let pkgContent; | ||
| try { | ||
| pkgContent = fs.readFileSync(filepath, "utf8"); |
There was a problem hiding this comment.
I don't like that we have sync FS access, but that's the case today as well, we can address that in a future change, it's internal anyway.
There was a problem hiding this comment.
As long as we use express we will have issues because express can not have async handlers.
|
🎉 This PR is included in version 13.0.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid with this PR to load some arbitrary file via require.
Require could result in issues in esm environments.