fix: use readFileSync and JSON.parse instead of require in probot-receive

[Uzlopak]

I guess you could actually load arbitrary code into probot receive cli command.

[AaronDewes]

You could, but I don't think it's an issue, maybe some people even want to generate the payload with JS here.

[Uzlopak]

@AaronDewes
Interesting aspect. We could also agree on documenting it accordingly, that a js file can also be used to generate the payload dynamically.

[AaronDewes]

@gr2m What's your opinion on this?

[gr2m]

You could, but I don't think it's an issue, maybe some people even want to generate the payload with JS here.

That was never an intended use. I'd go ahead with this change, if someone shows up complaining that we broke their use case, we can discuss it then. It's a problem when it's a problem

[Uzlopak]

@gr2m

Just for clarification: you want feedback by @AaronDewes before you merge, or is there something to do by me?

[gr2m]

I'd like to wait to get @AaronDewes' approval for only supporting JSON moving forward.

Is this a blocker?

[Uzlopak]

Not a blocker. Just better to be clear what the next steps are ;)

[github-actions]

🎉 This PR is included in version 13.0.0-beta.6 🎉

The release is available on:

• GitHub release
• npm package (@beta dist-tag)

Your semantic-release bot 📦🚀