fix(probot): passes logger to webhooks

[gr2m]

Current behavior:

const probot = new Probot({ log: myCustomLog });
probot.on("my_custom_event", handler);
// logs with console, not with `myCustomLog`

With this pull request, myCustomLog will be passed to webhooks and the warning will be logged using the passed logger instead of native console

[wolfy1339]

You aren't passing a file name here, so it should still be node-version

[gr2m]

yeah I know, just messing around

[gr2m]

@wolfy1339 any idea why the type errors suddenly occur? https://github.com/probot/probot/actions/runs/8902784149/job/24449370174?pr=2010

I see them locally as well, I'd expect given that it installs from the lock file, there should be unrelated errors

GitHub

fix(probot): passes logger to webhooks · probot/probot@6c599fc

🤖 A framework for building GitHub Apps to automate and improve your workflow - fix(probot): passes logger to webhooks · 6c599fc

[wolfy1339]

It seems there's a version mismatch between the version of @octokit/webhooks-types that is required in the version of @octokit/webhooks and the one required here.

As for the rest, I have to look deeper

[wolfy1339]

It seems these build failures have been happening for a while.

I think #1917 has some patches that resolves some of these issues, but it was never merged

[gr2m]

I think #1917 has some patches that resolves some of these issues, but it was never merged

Okay, I'll have a quick look, but this might not be worth the hassle then :(

[gr2m]

I'll check out #1917, maybe I can figure out the remaining failing test and get it merged after all

[gr2m]

I think I figured it out: 72231dc 🤞🏼

I gotta run home and take care of kids. If tests pass on #1917, feel free to merge it, I'll rebase this PR later

[gr2m]

once merged, I'll apply the fix to master as well. Should have started there, but ran into it in a project that still uses v12

[github-actions]

🎉 This PR is included in version 12.3.4 🎉

The release is available on:

• GitHub release
• npm package (@release-12.x dist-tag)

Your semantic-release bot 📦🚀