Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Simplify demo CSS watch configuration #1753

Merged
merged 2 commits into from Jan 13, 2022

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jan 12, 2022

tailwindcss can now notify postcss to regenerate the css file when the index.html changes. This let us use the standard postcss watch mode and remove the hack we set up with chokidar.

Resources

See https://v2.tailwindcss.com/docs/just-in-time-mode#styles-don-t-update-when-saving-content-files
Information found thanks to tailwindlabs/tailwindcss#6858 referenced in the tailwindcss changelog of #1750

tailwindcss can now notify postcss to regenerate the css file when the index.html
changes. This let us use the standard postcss watch mode and remove the hack we
set up with chokidar.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jan 12, 2022
@github-actions
Copy link

github-actions bot commented Jan 12, 2022

♻️ PR Preview b5d70dc has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jan 12, 2022

♻️ PR Preview b5d70dc has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tbouffard tbouffard merged commit bbc0470 into master Jan 13, 2022
@tbouffard tbouffard deleted the infra/simpify_demo_css_watch branch January 13, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants