Quad adds a diagonal line in WEBGL.

[StevesMakerspace]

p5.js version

1.7.0

What is your operating system?

Windows

Web browser and version

Edge 115.0.1901.203

Actual Behavior

When using WEBGL, quad function with stroke add a diagonal line through the center of the quad.

Expected Behavior

Quad with an outline but no diagonal line.

Steps to reproduce

function setup() {
createCanvas(500, 500, WEBGL);
translate(-width / 2, -height / 2);
background(150);
strokeWeight(3);
quad(30, 320, 185, 220, 205, 375, 50,405);
}

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[nsundriyal62]

this bug seems easy to solve
should i solve it directly and genrate PR
or you can assign it to me?

[lindapaiste]

This seems like an issue for the main p5.js repo rather than the web editor repo. I'm not able to transfer it but perhaps someone else can? @raclim @davepagurek @Qianqianye

[davepagurek]

I don't think I have permission on this repo, @Qianqianye would you be able to transfer this to the main repo?

@nsundriyal62 if you're interested in looking into this, feel free to go ahead! I can assign it to you once it's been transferred. The relevant code is in here:

p5.js/src/webgl/3d_primitives.js

Line 1578 in 45ada83

._makeTriangleEdges()

Rather than calling this function to add edges to every triangle, we should instead push pairs of vertex indices to quadGeom.edges to specify only the edges we want to see.

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

[davepagurek]

Thanks @raclim!

[nsundriyal62]

thanks for assigning
i am working on it

[Qianqianye]

Hi @nsundriyal62, thanks for offering help. Just to follow up on this issue, please let us know if you need any support to fix this bug.

[nsundriyal62]

@Qianqianye sorry to say but i forgot to work on this issue
actually i marked all assign issue as done and never remind about this one

i am working on it.

thanks for your help.

gonna raise a pr asap

[nsundriyal62]

@Qianqianye hello there

i tried a lot to understand the codebase and my whole day passes only setting up and and switching between multiple files.
i am new to this open source and solving this seems very difficult.

i think i am not able to solve this bug................. :(

so you can unassign this issue

sorry for taking so much time and this failure
maybe someone else can do it better

thanks for your time and offering help.

see u

[Qianqianye]

Thanks @nsundriyal62 for all of your effort. We are in the process of improving the p5.js WebGL contribution documentation to make contributing to WebGL issues easier in the future. Meanwhile, please feel free to have a look at open issues on p5.js if you'd like to contribute to another issue. Thanks!