done with issue #6383(problem of diagonal) #6487
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
@davepagurek is there any else to change in this pr? it's working fine as per requirment. |
| @@ -1575,7 +1575,7 @@ p5.RendererGL.prototype.quad = function(x1, y1, z1, x2, y2, z2, x3, y3, z3, x4, | |||
| } | |||
| quadGeom | |||
| .computeNormals() | |||
| ._makeTriangleEdges() | |||
| ._makeQuadEdges() | |||
There was a problem hiding this comment.
Nice work on the implementation of this! I wonder if maybe instead of making it a method on p5.Geometry, we could just inline it here, since it only can be used for single-quad shapes like this? So that would be something like:
quadGeom.computeNormals();
const vertexOrder = [0, 2, 3, 1];
for (let i = 0; i < vertexOrder.length; i++) { /* etc */ }
quadGeom.edgesToVertices();There was a problem hiding this comment.
Ok @davepagurek doing the changes.
|
@davepagurek i have made a new PR for this. #6488 |
|
I'm closing this one for organizational purposes because we merged the other PR here: #6488 |
Resolves #6383
Screenshots of the change:
before:
after:
PR Checklist
npm run lintpasses