Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of default fonts #6861

Merged
merged 1 commit into from Mar 14, 2024
Merged

Conversation

davepagurek
Copy link
Contributor

Resolves #6860

Changes

  • Only surrounds the font in quotes if necessary (if the font includes a space)
  • Adds visual tests

Screenshots of the change:
000

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@davepagurek davepagurek requested a review from dhowe March 14, 2024 17:17
@Qianqianye Qianqianye merged commit e1ca2e0 into processing:main Mar 14, 2024
2 checks passed
@Qianqianye
Copy link
Contributor

Thanks @davepagurek for reviewing it. I merged it before I saw that you requested a review from @dhowe. @dhowe, please leave comment here if you have any feedback, and we can make a new PR if needed. Thanks!

@davepagurek davepagurek deleted the fix/default-fonts branch March 14, 2024 18:32
@dhowe
Copy link
Contributor

dhowe commented Mar 19, 2024

looks good to me, thanks @davepagurek and @Qianqianye !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default fonts broken in 1.9.1
3 participants