New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main canvas clipping getting applied to framebuffers #6990

Merged

Qianqianye merged 1 commit into processing:main from davepagurek:fix/clip-fbo

Apr 24, 2024

+38 −0

Contributor

davepagurek commented Apr 22, 2024

Resolves #6989

Changes:

Makes sure the WebGL stencil check, which is what applies the clipping, is updated both when you start drawing to a framebuffer as well as when you stop (previously, it only did this when you stop)

Screenshots of the change:

The code in the issue now produces a red canvas in Chrome as expected:

PR Checklist

npm run lint passes
[Inline documentation] is included / updated
[Unit tests] are included / updated


          Fix main canvas clipping getting applied to framebuffers

ef4aa35

Qianqianye merged commit 4ba6ffc into processing:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment